Add Expression Function to Read File

arcalot / arcaflow-engine

Arcaflow is a highly-portable workflow engine enabling modular and validated pipelines through containerized plugins.

https://arcalot.io/arcaflow/

Apache License 2.0

7 stars 9 forks source link

Add Expression Function to Read File #166

Closed mfleader closed 8 months ago

mfleader commented 8 months ago

Changes introduced with this PR

[X] Add a function to the expression language to read a file into a string, and return that string
[X] Add unit tests

By contributing to this repository, I agree to the contribution guidelines.

mfleader commented 8 months ago

I'm not sure what other constraints we want to place on file access. Is there a canonical list of permitted/disallowed locations that we should be checking?

That's a great question. I do not know what we should disallow.

webbnh commented 8 months ago

I'm not sure what other constraints we want to place on file access. Is there a canonical list of permitted/disallowed locations that we should be checking?

That's a great question. I do not know what we should disallow.

We cannot enforce a policy which we do not have. Ship it! (Unless you want to tweak the nits, first....)