search

arcalot / arcaflow-engine

Arcaflow is a highly-portable workflow engine enabling modular and validated pipelines through containerized plugins.
https://arcalot.io/arcaflow/
Apache License 2.0
6 stars 9 forks source link

Transition to stage cancelled #173

Closed jaredoconnell closed 2 months ago

jaredoconnell commented 2 months ago

This fixes a potential deadlock in a specific case

By contributing to this repository, I agree to the contribution guidelines.

webbnh commented 2 months ago

The linter isn't happy with you, presumably because of this and this, which I think I agree with...but I don't know why the linter doesn't mind these on the main branch.

In any case, I would either remove the directives or add a comment to them explaining why we are disabling the directive instead of fixing whatever the linter is complaining about.

jaredoconnell commented 2 months ago

The linter isn't happy with you, presumably because of this and this, which I think I agree with...but I don't know why the linter doesn't mind these on the main branch.

In any case, I would either remove the directives or add a comment to them explaining why we are disabling the directive instead of fixing whatever the linter is complaining about.

Fixed. It's annoying when unrelated things break the linter in the CI. Likely a difference in version of the linter.