search

arcalot / arcaflow-engine

Arcaflow is a highly-portable workflow engine enabling modular and validated pipelines through containerized plugins.
https://arcalot.io/arcaflow/
Apache License 2.0
6 stars 9 forks source link

change method of setting config defaults #192

Closed dustinblack closed 3 months ago

dustinblack commented 3 months ago

Changes introduced with this PR

A change in PR #182 used an overly-complicated method of setting the defaults for the configuration. The existing schema definition already had defaults assigned, and in fact that change introduced a bug whereby a partial configuration file passed without a deployer defined will in fact default to docker rather than podman.

This update changes the default in the schema to podman, and it removes the statically-defined default config, opting instead to pass an empty map to the config.Load function, which has the effect of using the schema-defined defaults.

By contributing to this repository, I agree to the contribution guidelines.

dustinblack commented 3 months ago

Needs https://github.com/arcalot/arcaflow-reusable-workflows/pull/23 in order for the github actions to pass Apparently the action failures I saw after this initial commit were transient and not related to podman being missing from the reusable workflow, since for later commits the action has completed successfully from the main branch of the reusable workflow. ¯\(ツ)/¯