arcalot / arcaflow-engine

Arcaflow is a highly-portable workflow engine enabling modular and validated pipelines through containerized plugins.
https://arcalot.io/arcaflow/
Apache License 2.0
7 stars 9 forks source link

Cleanup on failure #25

Open dustinblack opened 2 years ago

dustinblack commented 2 years ago

Please describe what you would like to see in this project

Currently if a workflow fails to complete because of an error condition, the artifacts already created (containers or other kubernetes objects) are left in their most recent state and require manual cleanup. The engine should instead capture the failure state and delete the stale artifacts.

Please describe your use case

Particularly when developing new workflows and plugins and running frequent deployment tests, the stale artifacts can build up quickly and can create conflicts. But even in more "production" use cases, I don't think we want to leave these things lingering on the system.

Additional context

I think cleanup should be the default behavior, but I suspect there are reasons we may want to have the option to override the behavior and leave the stale artifacts in place.

ghost commented 1 year ago

This should be resolved by #32

ghost commented 1 year ago

@dustinblack this should be resolved with the new engine, please verify.