search

arcalot / arcaflow-expressions

Expressions language for Arcaflow
Apache License 2.0
0 stars 0 forks source link

Replace code with new assertion #25

Open jaredoconnell opened 3 months ago

jaredoconnell commented 3 months ago 
        var grammarErr *InvalidGrammarError
    ok := errors.As(err, &grammarErr)
    if !ok {
        t.Fatalf("Returned error is not InvalidGrammarError")
    }

It seems like it would good to refactor this into

    assert.ExpectedError(&grammarErr)

with the code moved to go-assert/error.go.

_Originally posted by @webbnh in https://github.com/arcalot/arcaflow-expressions/pull/23#discussion_r1464037373_