arcan1s / awesome-widgets

Minimalistic Plasmoid set
https://arcanis.me/projects/awesome-widgets/
GNU General Public License v3.0
74 stars 4 forks source link

abstractextitem.h:81: Parse error at ";" #147

Closed akwala closed 3 years ago

akwala commented 3 years ago

Compile error with 3.4.2 source:

/path/to/awesome-widgets-3.4.2/sources/awesomewidgets/abstractextitem.h:81: Parse error at ";"

make[2]: *** [awesomewidgets/CMakeFiles/awesomewidgets_autogen.dir/build.make:58: awesomewidgets/CMakeFiles/awesomewidgets_autogen] Error 1
make[1]: *** [CMakeFiles/Makefile2:685: awesomewidgets/CMakeFiles/awesomewidgets_autogen.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

cmake & make output: awesome-widgets-3.4.2_compile-err.txt

arcan1s commented 3 years ago

which os are you using?

akwala commented 3 years ago

which os are you using?

Kubuntu 20.04

arcan1s commented 3 years ago

should be fixed with 0c443e9, but it still requires patch from https://github.com/arcan1s/awesome-widgets/blob/development/patches/qt5.14-splitbehavior-and-qset.patch. I will create tag later with built package later

akwala commented 3 years ago

Building 3.4.3 code...

several warnings like:

/path/to/awesome-widgets-V.3.4.3/sources/awesomewidgets/yahooweatherprovider.h:38:36: warning: 'nodiscard' attribute directive ignored [-Wattributes]
     [[nodiscard]] QUrl url() const override;
                                    ^
/path/to/awesome-widgets-V.3.4.3/sources/awesomewidgets/yahooweatherprovider.h:42:77: warning: 'nodiscard' attribute directive ignored [-Wattributes]
                                             const QVariantMap &_atmosphere) const;
                                                                             ^

...then:

[ 15%] Building CXX object awesomewidgets/CMakeFiles/awesomewidgets.dir/__/awdebug.cpp.o
/path/to/awesome-widgets-V.3.4.3/sources/awdebug.cpp: In function 'QString AWDebug::getAboutText(const QString&)':
/path/to/awesome-widgets-V.3.4.3/sources/awdebug.cpp:70:73: error: 'SkipEmptyParts' is not a member of 'Qt'
         QStringList trdPartyList = QString(TRDPARTY_LICENSE).split(';', Qt::SkipEmptyParts);
                                                                         ^
/path/to/awesome-widgets-V.3.4.3/sources/awdebug.cpp:78:65: error: 'SkipEmptyParts' is not a member of 'Qt'
         QStringList thanks = QString(SPECIAL_THANKS).split(';', Qt::SkipEmptyParts);
                                                                 ^
make[2]: *** [awesomewidgets/CMakeFiles/awesomewidgets.dir/build.make:145: awesomewidgets/CMakeFiles/awesomewidgets.dir/__/awdebug.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:658: awesomewidgets/CMakeFiles/awesomewidgets.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
arcan1s commented 3 years ago

yeah, in qt < 5.14 this enumeration is in QString namespace. There is a patch to provide qt<5.14 compatibility

akwala commented 3 years ago

FYI... In the source archives of 3.4.3, sources/3rdparty/fontdialog is empty. Build only succeeded after I put the corresponding *.cpp & *.h files there.