arcana-lab / noelle

NOELLE Offers Empowering LLVM Extensions
MIT License
75 stars 36 forks source link

Fix default behavior of NOELLE with and without SCAF #123

Closed tommymcm closed 7 months ago

tommymcm commented 7 months ago

The file src/core/loop_content/src/LoopAwareMemDepAnalysis.cpp contains a hardcoded #define ENABLE_SCAF. This requires individuals who want to compile NOELLE without SCAF to both use the specified make rule in external/Makefile and make modifications to the program.

Proposed changes:

  1. Quick fix: Wrap ENABLE_SCAF in an ifdef so that it will take on the environment definition and change uses of it to be #if instead of #ifdef so that it can be toggled with 1 or 0.
  2. More robust: Create an ENABLE_SCAF environment variable in the top-level Makefile, which will select the external/Makefile rule and set the environment variable for the file in loop_content (and any future users)