remove unused variable and code optimization

arcanis / clipanion

Type-safe CLI library / framework with no runtime dependencies

https://mael.dev/clipanion/

1.11k stars 64 forks source link

remove unused variable and code optimization #117

Closed MrJithil closed 1 year ago

MrJithil commented 2 years ago

Completed a TODO task

MrJithil commented 2 years ago

CC: @arcanis

MrJithil commented 2 years ago

Still pending?

MrJithil commented 2 years ago

Can we merge it?

arcanis commented 2 years ago

I prefer not - as the comment says, there's likely a bug here, and just removing the comment and the usage feels the less ideal option (compared to figuring out for sure what's the right behavior).

Given that your change has no functional impact, I prefer to keep the strange code as it is until we figure it out.