arcanistzed / ctg

Group combatants in the Combat Tracker and roll group initiative.
https://arcanist.me
MIT License
1 stars 9 forks source link

[Bug]: Module Conflict with Hidden Initiative #13

Closed Cubius closed 2 years ago

Cubius commented 2 years ago

Expected Behavior

Initiative should progress in descending order.

Current Behavior

Hidden Initiative will generate a random order of combatants to display initially just for players - not for GMs - and with each turn reorder to reveal the actual order.

As of the latest version of Combat Tracker Groups, when starting a combat, when skipping to the next turn will not follow the numbers of initiative in descending order, but rather jump through the combatants in a random sequence instead. I suspect that it is following the fake order Hidden Initiative is generating instead.

Steps to Reproduce

  1. Install both Hidden Initiative and Combat Tracker Groups.
  2. Start a combat. More combatants is better to illustrate the issue, I recommend at least 5 combatants.
  3. Roll initiative and click to advance to the next turn.

Context

No response

Version

1.1.0

Foundry VTT Version

9.269

Operating System

Linux

Browser / App

Chrome, Firefox

Game System

dnd5e (1.6.3)

Modules Disabled

arcanistzed commented 2 years ago

Could you show me a screenshot of your Combat Tracker Groups module settings? Specifically, I'm curious if you have "Sort Combatants" enabled and which Grouping Modes you are using.

Cubius commented 2 years ago

Sort Combatants is indeed enabled as you can see below:

grafik

grafik

I first noticed this issue in a combat with a group of enemies, but it also occurs with ungrouped individual actors.

arcanistzed commented 2 years ago

Which of those grouping modes are you actually using?

arcanistzed commented 2 years ago

With the default "Initiative" mode, the turn order advances from highest to lowest initiative properly for me. If you disable "Group Skipping" it's even easier to see that it is working properly.

Cubius commented 2 years ago

I think I see what you are talking about. It seems I did not fully understand the grouping functionality.

I would rephrase my issue to be then that the various modes do not just group combatants, but sort them too.

'Grouping' by name just sorts individual actors by name instead of initiative.

grafik

The same seems to apply to the other modes. Grouping by 'None' meanwhile appears to just be a seemingly random order - I would suspect the order combatants were added to the tracker.

grafik

If this is functioning as intended, obviously mark this issue as closed, but I would expect combatants to be grouped by the desired metric, while combat still progresses in descending order through initiative rather than completely disregarding initiative and going alphabetically or otherwise.

arcanistzed commented 2 years ago

I think that what you are describing can be achieved by simply disable the "Sort Combatants" setting. The goal of that feature is to sort the combatants by the same attribute that they are being grouped by which makes "Group Skipping" more predictable.

Cubius commented 2 years ago

Apparently turning off "Sort Combatants" does what it's name implies.

A little counter-intuitive to the description of that setting.

I saw a fair bit of the tracker jumping backwards or randomly skipping around with the setting still enabled. Potentially that might have been an issue with having two accounts with GM permissions on different sorting modes. I'll investigate if that has caused some of my issues, but for now close the issue.

Thanks for the help though!

arcanistzed commented 2 years ago

Yeah. The "Sort Combatants" setting basically decides whether CTG applies any of its own logic to the turn order, so disabling it will mean that you are using the default sorting of your game system.