search

arcanistzed / ctg

Group combatants in the Combat Tracker and roll group initiative.
https://arcanist.me
MIT License
1 stars 9 forks source link

[Bug]: Mode buttons missing in v10 #35

Open jagoe opened 2 years ago

jagoe commented 2 years ago

Expected Behavior

In Foundry v10, the mode buttons should appear in the combat tracker.

Current Behavior

The mode buttons do not appear.

Steps to Reproduce

  1. Use Foundry v10
  2. Open the combat tracker
  3. No mode buttons

Context

From what I can tell, the reason is that the module expects #combat > #combat-round to exist, but it does not. I could produce the correct behavior by changing the query to .combat-tracker-header.

Version

1.4.3

Foundry VTT Version

10.290

Operating System

Windows, Linux (Mint)

Browser / App

Chrome

Game System

dnd5e (2.0.3)

Modules Disabled

AuraofMana commented 1 year ago

It's been more than a month. Why hasn't this been merged yet? @arcanistzed

Haxxer commented 1 year ago

It's been more than a month. Why hasn't this been merged yet? @arcanistzed

  1. It's the end of the year, people are on holidays and/or are busy with non-foundry things.
  2. No one owes you anything, we module developers do this for fun, on our free time, FOR FREE. Your entitled attitude is what drives people away from making this vibrant community what it is, and leaves a sour taste in developers' mouths.
  3. There are a thousand different ways that you could have nicely asked if there's a timeline for a merge, instead of the rude sentence you offered.
  4. Hell, you're not even the contributor of the fix.
AuraofMana commented 1 year ago

Ahh, I sincerely apologize. I just realized I wrote it in a way that sounds rude. I meant to ask about the timeline. Definitely wasn't my intent, sorry!