search

arcanus55 / neodigm55

An eclectic low-code vanilla JavaScript UX micro-library for those that defiantly think for themselves.
https://thescottkrause.com/emerging_tech/neodigm55_ux_library/
BSD 3-Clause "New" or "Revised" License
17 stars 2 forks source link

Neodigm Utils Shake | Accept an Element ref or a query string #88

Closed neodigm closed 12 months ago

neodigm commented 12 months ago

It makes sense to clearly define the contract signature before beginning work on TypeOn.

If possible make backward compatible.

Consider this use case wherein the query results in more than one element (loop).

neodigm commented 12 months ago

FYI - This is an easy task.

neodigm commented 12 months ago

I wonder if Shake and TypeOn should return an instance of neodigmUtils or a collection of effected elements?

Not sure that I agree with the premiss that we should pass in an element reference. It seems like its breaking established norms.

neodigm commented 12 months ago

Decided not to make this backward compatible, I don't think that it should except an element. Its too much trouble for the implementation coder (DX).

The chaining works like this:

neodigmUtils.shake( "#js-hearts" ).shake( "#js-clubs" ).shake()

I am going to close this shortly, but based on the description of the task, I may mark it "not fixing", or whatever.

neodigm commented 12 months ago

This issue is resolved in v3.1. No doc changes needed.