Lua 5.3 support

[daurnimator]

I tested out 5.3 support today, worked at a basic level by merely adding -DLUA_COMPAT_APIINTCASTS to CFLAGS. The reason for this is the removal of luaL_checkint, use luaL_checkinteger instead.

For complete support, I think the only other thing would be supporting 64bit ints in get_sql_params in LUA_TNUMBER case:

• check lua_isinteger, if true:
• paramTypes[n] = INT8OID;
• *(uint64_t *)paramValues[n] = htobe64(lua_tointeger(L, t))

[mbalmer]

Thanks, changed it accordingly, but could not yet test it on a 5.3 Lua (no regression on 5.2, though).

[daurnimator]

I saw you briefly post the diff here and delete it (probably due to messed up formatting, surround in diff\npaste here\n to get mono-spaced and syntax highlighted on github).

My comments on that diff:

• I'm not sure if swap.i = lua_tointeger(L, t); results in loss of precision? or might have undefined behaviour on overflow? I'd have to check the C standard here...
• Remember to #define INT8OID 20
• Update the rockspec to say you support 5.3 under 'dependencies': "lua >= 5.1";

[mbalmer]

afaict, swap.i and the value returned by lua_tointeger are of the same size. The other issues have been addressed.

[daurnimator]

afaict, swap.i and the value returned by lua_tointeger are of the same size.

Yep. Just I wasn't sure what would happen as lhs is unsigned, rhs is signed.

The other issues have been addressed.

Yes, Thankyou. I haven't tested it out yet though.