Prevent segfaults when using :trace()

arcapos / luapgsql

Lua binding for PostgreSQL

108 stars 24 forks source link

Closed daurnimator closed 8 years ago

daurnimator commented 9 years ago

Addresses issues in #23

close functions are wrapped as discussed on IRC and in https://github.com/mbalmer/luapgsql/issues/23#issuecomment-76756882
I also attach the file object to the PGconn userdata so that it won't get collected if it leaves scope (which allows the nice pattern of function enableTracing(conn, filename) local f = io.open(filename, 'w') conn:trace(f) end

The code became a bit bloated due to the different way file handles work in lua 5.1 combined with the coding style.

daurnimator commented 9 years ago

Misc note: closef_untrace has to use relative indexes for everything except the file object itself due to idiosyncrasies in lua 5.1.

daurnimator commented 9 years ago

I updated the pull request to clean out the uservalue table in :finish() as discussed on irc.

daurnimator commented 9 years ago

Can you look into merging this?

daurnimator commented 9 years ago

ping?

mhenrixon commented 8 years ago

Hello?