search

arcapos / luapgsql

Lua binding for PostgreSQL
108 stars 24 forks source link

Lua 5.2 support #60

Closed drTr0jan closed 1 year ago

drTr0jan commented 1 year ago

There's a regression after https://github.com/arcapos/luapgsql/commit/1d9ffb635a6161aebc97ab19bd890a0029b030de

lua_getfield() should return void in Lua < 5.3.

mbalmer commented 1 year ago

I think the right way to deal with this situation is to drop support for old Lua versions altogether. Lua is easy to upgrade.Am 18.08.2023 um 17:22 schrieb Boris Korzune @.***>: There's a regression after 1d9ffb6 lua_getfield() should return void in Lua < 5.3.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

drTr0jan commented 1 year ago

@mbalmer, I think it's good idea to specify supported Lua versions in Readme, isn't it? Thx!

mbalmer commented 1 year ago

That, or someone who still uses 5.2 may propose a proper pull request with #ifdefs?Am 19.08.2023 um 15:11 schrieb Boris Korzun @.***>: @mbalmer, I think it's good idea to specify supported Lua versions in Readme, isn't it? Thx!

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>