arcemu / arcemu

World Of Warcraft 3.3.5a server
GNU Affero General Public License v3.0
364 stars 210 forks source link

Spells with multiple stacks #102

Open Appled opened 12 years ago

Appled commented 12 years ago

This is not mandatory issue. It just spams combat log and your screen. It works otherwise well.

For example, let's take paladin's Seal of Vengance. When you have this seal up your every melee attack will apply one stack of Holy Vengeance on the target. Now when you have all the 5 stacks on your target they'll do seperate damage. It's hard to explain because English is not my native language.

Picture explains more than my words (yes, combat log was added afterwards to that picture and it's arcemu 1542910 commit(the latest)): http://img403.imageshack.us/img403/1683/arcemu.jpg

As you can see from the image that all stacks will do separate damage instead of combined damage. Here you can see a video from some random private server but that's how it should work: http://www.youtube.com/watch?v=IK95CQGUesM

Now, this happens with all spells which has multiple stacks. Druid's Lifebloom being one aswell.

neo-mat commented 12 years ago

Confirmed, that shouldn't be working like this, just for every stack with Periodic Trigger effect we are using 3 events, that's the cause. I think it's better to ask someone who has idea about EventMgr how to solve it, for example dfighter :)

dfighter1985 commented 12 years ago

EventMgr sucks, and indeed it shouldn't be working like this...

andy012345 commented 12 years ago

This is actually a design fault with auras. Each stack is considered a separate aura.