search

arceos-hypervisor / arceos

An experimental modular OS written in Rust.
http://rcore-os.cn/arceos/
Apache License 2.0
3 stars 9 forks source link

[feat]Adapting for rk3588. #28

Closed luodeb closed 1 month ago

hky1999 commented 1 month ago

please cherry-pick your modifications to the newest vmm branch see PR #29

luodeb commented 1 month ago

please cherry-pick your modifications to the newest vmm branch see PR #29

Resolved.

hky1999 commented 1 month ago

please cherry-pick your modifications to the newest vmm branch see PR #29

Resolved.

I do not get it. Do you want to merge all these commits into vmm branch?

luodeb commented 1 month ago

please cherry-pick your modifications to the newest vmm branch see PR #29

Resolved.

I do not get it. Do you want to merge all these commits into vmm branch?

Ok, rebase it.

hky1999 commented 1 month ago

hv related platform config file have been totally removed from arceos-hypervisor/arceos

see this PR for details

hky1999 commented 1 month ago

I think you can leave platforms/aarch64-rk3588j.toml here.

move platforms/aarch64-rk3588j-hv.toml into arceos-umhv/arceos/arceos-vmm/platforms, and use make xxx PLATFORM=platforms/aarch64-rk3588j-hv.toml build for building

luodeb commented 1 month ago

Removed the rk3588 configs from ./platforms.

hky1999 commented 1 month ago

I think you can leave platforms/aarch64-rk3588j.toml here.

move platforms/aarch64-rk3588j-hv.toml into arceos-umhv/arceos/arceos-vmm/platforms, and use make xxx PLATFORM=platforms/aarch64-rk3588j-hv.toml build for building

I mean, you can leave platforms/aarch64-rk3588j.toml here in ArceOS, as a arceos builtin platform

only move aarch64-rk3588j-hv.toml to arceos-umhv

Sorry for misstanding, but why did you just remove all rk3588 related platform configs...

luodeb commented 1 month ago

I think you can leave platforms/aarch64-rk3588j.toml here. move platforms/aarch64-rk3588j-hv.toml into arceos-umhv/arceos/arceos-vmm/platforms, and use make xxx PLATFORM=platforms/aarch64-rk3588j-hv.toml build for building

I mean, you can leave platforms/aarch64-rk3588j.toml here in ArceOS, as a arceos builtin platform

only move aarch64-rk3588j-hv.toml to arceos-umhv

Sorry for misstanding, but why did you just remove all rk3588 related platform configs...

I was wrong. I incorrectly assumed that only a config.toml would be needed.

hky1999 commented 1 month ago

BTW, please add a doc in doc directory to explain how to boot ArceOS on RK3588 hardware, just like https://github.com/arceos-hypervisor/arceos/blob/vmm/doc/platform_raspi4.md

You can put the link of BSP tools and scripts in your doc