search

arcfide / chez-srfi

SRFIs for Chez Scheme
Other
94 stars 36 forks source link

Installation bugfixes #66

Closed paralogismos closed 3 years ago

paralogismos commented 3 years ago

During chez-srfi installation a compiler exception was occurring with SRFI-116 due to a missing library form in the %3a116.sls file.

Compiler exceptions were also occurring during installation with SRFI-146 due to library files with file extension .scm instead of .sls.

This pull request fixes those issues. Installation worked without problems after making these changes.

arcfide commented 3 years ago

Hrm, I'm merging this in, but I'm wondering why the need to shift the extensions, or why they weren't that way in the first place? I'm kind of hoping that there isn't something more systemic wrong, but thanks for the patch!

akce commented 3 years ago

I can explain this one.

Sorry for coming in late; my only excuse is that i haven't found myself using srfi's so this repo slipped off my radar.

The problems come from the install script i created that you kindly merged in sometime around late August 2020.

install discovers r6rs lib files by assuming they've got an .sls extension and that either they define the entire library or that they'll include/resolve implementation files. It was a pattern that held until November 2020 with the addition of the srfi's referenced in this PR.

Maybe trying to detect libs was a bad idea and instead it should work from a list (eg, from the private/registry files).

I might create an issue around improving and documenting the install process and perhaps codifying any steps for adding new srfi's..

arcfide commented 3 years ago

Thanks for clearing this up. I'd have to think more about the correct solution, so I'm happy to have you explore a better way to do this.

akce commented 3 years ago

Beauty. I've been having a look too and i can see plenty to be improved.

Anyway, i'll raise the issue shortly.