arch-kiosk / arch-kiosk-office

💼 central place for collaboration
GNU Affero General Public License v3.0
1 stars 0 forks source link

define default todo registration codes depending on material type #1817

Closed urapadmin closed 2 years ago

urapadmin commented 2 years ago

As there is a typical workflow for certain materials / collected material types we could create default registration codes for every collected material. Ceramics need to be washed, small finds need to be photographed, etc. ..

urapadmin commented 2 years ago

recording 13.7.6

urapadmin commented 2 years ago

you can also test if this covers these urap requirements: #34

luizaogs commented 2 years ago

I'm feeling a bit stupid but should I know what the B stands for? I don't see a B in any of the value lists.

Or L! ???

luizaogs commented 2 years ago

In PVD we have these set for materials:

Screenshot 2022-11-20 at 7 19 52 PM

I first had a small find set as beads, and then changed it to ceramic, and ended up with this code combination:

Screenshot 2022-11-20 at 7 25 21 PM

Is this what you intended to happen? It seemed to me like the 5th bullet point above says so, but I'm a bit confused so wanted to check.

luizaogs commented 2 years ago
  • in both default settings a combination of codes lists the codes seprated by comma. E.g. B,R or B,C!. This is because theoretically codes can have more than two digits (see C!, but adding a ! should be the only reason to make a code having two digits).

Currently this is not the case and it seems to be working fine. Not sure if it should.

luizaogs commented 2 years ago

Everything else seems to be working.

urapadmin commented 2 years ago
  • in both default settings a combination of codes lists the codes seprated by comma. E.g. B,R or B,C!. This is because theoretically codes can have more than two digits (see C!, but adding a ! should be the only reason to make a code having two digits).

what is not the case currently?

urapadmin commented 2 years ago

In PVD we have these set for materials:

Screenshot 2022-11-20 at 7 19 52 PM

I first had a small find set as beads, and then changed it to ceramic, and ended up with this code combination:

Screenshot 2022-11-20 at 7 25 21 PM

Is this what you intended to happen? It seemed to me like the 5th bullet point above says so, but I'm a bit confused so wanted to check.

no, the double W is redundant. It would have been correct if you had first made a ceramic (WC) and then switched to bead (W) and the result had been WC because the C would stay from the former type.

luizaogs commented 2 years ago
  • in both default settings a combination of codes lists the codes seprated by comma. E.g. B,R or B,C!. This is because theoretically codes can have more than two digits (see C!, but adding a ! should be the only reason to make a code having two digits).

what is not the case currently?

There are no commas right now, anywhere.

urapadmin commented 2 years ago

ah! Well, then the configuration is wrong! it must be ceramics=W,C and beads=W. Sorry, I didn't see it. And that might explain the WWC issue above. In that case WC is treated as a single code which is different from W. Please try again with the correct comma.

luizaogs commented 2 years ago

Ok yes, with the commas the change from beads to ceramic leads to BRPWC, which seems correct.

luizaogs commented 2 years ago

I still don't know what B and L! are doing there but the rest seems ok.

urapadmin commented 2 years ago

I don't know. Might have been test stuff from former tests? The codes are really entirely up to whatever somebody chooses to configure. My "B" in my instructions has no meaning. It is a registration code I use in my very own project. It stands for, erm, bullsh... or brushit ... For the recording system it is all just some letters without meaning. Except for H and R. They are hard-coded into the views.

urapadmin commented 2 years ago

It's abstract :o) That's how I like my stuff.

luizaogs commented 2 years ago

Oh. I thought they were supposed to be doing something specific and I was missing it :) Nevermind, then. This is working.

lbestock commented 2 years ago

Configuring URAP test. I did this on my mac after uploading my patch and feeling appreciative of Kiosk. The current registration_code_cm_type_defaults is: bulk=H small_find_H, P, R sample=H, R This is the expected actual configuration for URAP. But making a small find has not triggered the application of any registration todo codes that I can see in the CM record (whereas it worked properly for bulk).

lbestock commented 2 years ago

Oh whoops, that is not material type...

lbestock commented 2 years ago

Nor does sample result in any codes whatsoever.

The material type applied (ceramic=WC) does get properly applied.

luizaogs commented 2 years ago

That’s so weird, it worked in PVD.

luizaogs commented 2 years ago

Typing everything in FM in URAP worked.