search

arch-kiosk / arch-kiosk-office

💼 central place for collaboration
GNU Affero General Public License v3.0
1 stars 0 forks source link

file sequence import: Use not-matching end marker as new start marker #2275

Open urapadmin opened 1 year ago

urapadmin commented 1 year ago

USTP revealed that sometimes sequences are not closed properly. In that case the import runs into a marker that does not fit the existing start marker. So something like A ... B ... B. In this case one could discard the [A ... ] since B is not a proper end to it and then assume B as a start qr code rather than a wrong end qr code. This would also help with what I have seen on occasion: When a qr code was clicked twice: A ... A A B ... B. Currently in such a case A ... A will be imported, then the third A interpreted as a start but the B not as a match to that start. It would make sense to just use B again as a start marker.

urapadmin commented 1 year ago

hm. The code reads to me as if that is the already case. That needs some more in depth testing because I am sure some of the USTP import issues would not have happened if that were working properly.

urapadmin commented 4 months ago

we had issues with a PASU test import, lbestock conducted. There it was definitely that the files were not in the correct order and photos for sequence and bulk were mixed in the folders (which is fine, except if the files are not in the right order anymore).

So inconclusive. Still much can go wrong with file imports and even if it is almost always an issue caused by users, the outcome is always so puzzling that I am not happy with it all in all.

But: postponed due to inconclusive data