arch-kiosk / arch-kiosk-office

💼 central place for collaboration
GNU Affero General Public License v3.0
1 stars 0 forks source link

q&v chart: allow for multiple charts per chart type #2687

Closed urapadmin closed 5 months ago

urapadmin commented 5 months ago

In the first version only one chart per type was allowed. Hence we only have a pie chart and a bar chart. Now what we really need is the ability to define several charts per query (based always on the exact same data). Each chart type gets a selector that allows to switch between the charts. We keep the title in the chart so that it gets exported in the image export.

urapadmin commented 5 months ago

Kiosk 1.5.33

luizaogs commented 5 months ago

It took me a while to figure out how to change from weight to count. I don't know if moving the dropdown to the left would help? At least that's where my eye goes first, rather than to the right where it currently is.

luizaogs commented 5 months ago

I also note that the percentages for the graphs in Kiosk have more decimal spaces, presumably because there is more space. So it's the same results but the Kiosk graphs have a higher level of accuracy / specificity.

luizaogs commented 5 months ago

Don't know if you want a separate ticket for this so I don't open one yet. Weird thing in PVD: I was trying to see how the graphs were working for the "what materials and how much" query and first tried pulling it up for LA, but that was a crappy spread of data so then I switched to PBA, which was better. But somehow I've ended up with the results for PBA (you can see that PBA is in the selection box) but a label for the graph mentioning LA (see first screenshot). I keep the LA label for this graph even if I toggle between weight and quantity (see second screenshot):

Screenshot 2024-04-30 at 9 30 34 PM Screenshot 2024-04-30 at 9 35 50 PM

Meanwhile the bar graph looks ok (see third screenshot):

Screenshot 2024-04-30 at 9 32 48 PM
luizaogs commented 5 months ago

Also, for the "what materials and how much" query the pie chart starts with the default view of quantity whereas the bar graph starts by default on weight. Does it make sense to start the two on the same one, either quantity or weight?

urapadmin commented 5 months ago

It took me a while to figure out how to change from weight to count. I don't know if moving the dropdown to the left would help? At least that's where my eye goes first, rather than to the right where it currently is.

The title stacked twice looked unappealing. I got rid of the title in the graph now. On second thought it might be better that way. If people want to copy the chart into a document they might prefer it without the title in order to avoid a different font. So the selector is kinda the title now. If there isn't anything to select the dropdown button vanishes and it does not drop.

urapadmin commented 5 months ago

Kiosk 1.5.33.1

luizaogs commented 5 months ago

I'm still finding the selector hard to see/find, but maybe I'm just being picky and you should get a second opinion from @lbestock

Is there a way to move the arrow of the drop down to the left, close to the graph title? It's so far away.

urapadmin commented 5 months ago

ja, that's what I feared would happen next. The selector is now far away from the text.

I cannot move the arrow closer to the text because I do not know where the text ends. I can set it to a fixed width but then we risk cutting of some titles, which would be worse.

So the only option that's left would be making the title right aligned again. That way your eye would not find a title anymore where it expects it (on the left), you would go search for it and find it with the arrow next to the title. Or I put the arrow in front of the right aligned text. But that is rather unusual.

But this is also a thing that once found out is learned (We have drop down arrows on the right in other places in Q&V, too). So I would not want to jump through too many more loops with this.

luizaogs commented 5 months ago

Ok, if you don't want to move it before the text (that might be easier to find, even if it's not usually where one would put an arrow) then this is good to go.

luizaogs commented 5 months ago

Sorry, Lutz.

Screenshot 2024-05-02 at 12 48 16 PM
urapadmin commented 5 months ago

Ha. I hadn't looked at this because yesterday the room was turning around me most of the day when I looked at anything. (Covid is really nasty). But also because I feared you found another bug in the charting library. What a charming way to put the user-designer conundrum (and Bob and Huxley prove this every day). Made me smile :o) (which still makes the room wobble)

luizaogs commented 5 months ago

I'm so sorry you're still feeling so poorly :( I hate covid.

urapadmin commented 5 months ago

kiosk 1.5.33.3

urapadmin commented 5 months ago

not that cats usually follow signs, but I hope the cat / user analogy isn't going too far :o)

luizaogs commented 5 months ago

Your incompetent human user says thank you.