Q&V: symbolic data references in chart titles have underscores if the default is being returned

arch-kiosk / arch-kiosk-office

💼 central place for collaboration

GNU Affero General Public License v3.0

1 stars 0 forks source link

Q&V: symbolic data references in chart titles have underscores if the default is being returned #2698

Closed urapadmin closed 5 months ago

urapadmin commented 5 months ago

The statement is: "#: #(/$/glossary/collected_material_types) in #(/$/constants/labels/unit) #(/variables/inputs/unit_id) by weight" And I thought if there is no key collected_material_types in the glossary this should return collected material types, so the underscores should be replaced with spaces automatically.

Not the case.

urapadmin commented 5 months ago

kiosk 1.5.33.3

underscores are now replaced with spaces by default. If we find side effects of that, I have to think about defaults again. But currently I believe that underscores are so rarely a character with meaning that I'll risk it.
whether it does what it should (not if it does things it shouldn't) you can see n the chart titles of query "What materials (and how much ...". Three the charts 'collected material type in ..." should not have underscores.

luizaogs commented 5 months ago

Hmm no, I still see underscores in PASU:

urapadmin commented 5 months ago

that's a different problem. Here the underscore is actually in the data. I know, that's hard to distinguish for you. But what this ticket is about is rather titles, labels etc. Not data values themselves. So the label for collected material type should be free of underscores while the value of the collected material type can still actually have an underscore.

urapadmin commented 5 months ago

hence I referred you to the chart titles as a test case

luizaogs commented 5 months ago

Sorry. I didn't catch the "title" part of your comment above, just that it pertained to this query. I'll look again.