kiosk: director's view loading vaadin stuff again

arch-kiosk / arch-kiosk-office

💼 central place for collaboration

GNU Affero General Public License v3.0

1 stars 0 forks source link

kiosk: director's view loading vaadin stuff again #2863

Open urapadmin opened 1 month ago

urapadmin commented 1 month ago

not a time zone issue but occurs strangely in the new Kiosk > 1.6: Director's view does not load because of some Vaadin library confusion:

Not the first time I battle that kind of Vaadin trouble

urapadmin commented 1 month ago

Kiosk 1.6.4.2

Quick fix: Director's view should load again for now: the error is logged to the JS console but does not stop the director's view from loading anymore:

urapadmin commented 1 month ago

the quick fix solves the problem for now. But it is a hacky solution that just suppresses the error. I am not really sure why the Director's view reacts like that (which is totally reasonable) but Q&V does not (that's the part I don't understand).

My guess is that Q&V benefits from the new dynamic app loading technique I invented for #2691: https://wiki.arch-kiosk.brown.edu/urapdev/doku.php?id=manuals:developer_manual:kiosk_front-end_apps&s[]=dynamic&s[]=app

I should apply that to the Director's view and see if the errors in the JS console still happen.

luizaogs commented 1 month ago

Do you want me to test this? Not in testing but in the release notes so I wasn't sure...

urapadmin commented 1 month ago

there is not test needed, director's view simply starts again for now. But my task is not complete.

luizaogs commented 1 month ago

Ok, sorry!

urapadmin commented 4 weeks ago

Kiosk 1.6.6

directorsview is now dynamically loaded, as it should
that did not help, though. The vaadin issues prevail: vaadin-lumo-styles and vaadin-input-container are tried to register again and that is still not the case in the current query and view version. Very mysterious. But for now not critical. I just wish I'd understand.

urapadmin commented 1 week ago

taking this out of time zone because it is actually an architectural issue that all plugins potentially have