search

arch4edu / aur-auto-update

Automatically update PKGBUILDs on AUR
26 stars 9 forks source link

Keyoxidizer version isn't recognized correctly #27

Closed bordam closed 1 year ago

bordam commented 1 year ago

Probably an issue from my side, but I don't know how to fix this. Version "v.2.4.0" isn't converted to "2.4.0" by nvchecker, causing it to flag it as outdated in the new version check

bordam commented 1 year ago

I checked the action and it’s still not working… do you know what’s wrong?

petronny commented 1 year ago

Hi, I see that keyoxidizer on AUR is at version 0.2.4 and the latest version on github is also 0.2.4.

So the bot will see that keyoxidizer is already up to date and won't do anything.

bordam commented 1 year ago

Hmm, ok, but I don't understand why nvchecker flags it as outdated

petronny commented 1 year ago

Oh, it's nvchecker you are talking about.

nvchecker compares the newly obtained version (newver) with the previously obtained version (oldver), not the version on AUR (and it won't know about it neither). If they are not same, then nvchecker will say this package is out of date.

In this case, the oldver is v.0.2.4 and the newver is 0.2.4. So nvchecker will see it as an update and let the bot run the auto update script. And so does it when there is no oldver.

The auto update script will strip those non-version characters from newver and compare it to the version on AUR. Then update the version if they are different. For this package, they are same so the update script is runned just for sure.

Everything is working as expected for this package, don't worry :)

bordam commented 1 year ago

I see, thank you so much for this explanation 🙂