search

archagon / sensible-side-buttons

A macOS menu bar app that enables system-wide navigation functionality for the side buttons on third-party mice.
http://sensible-side-buttons.archagon.net
GNU General Public License v2.0
1.91k stars 125 forks source link

Stopped working with Chrome #58

Open jofbe opened 3 years ago

jofbe commented 3 years ago

Hello!

Thank you for this great tool, I'm using it for years now. Just recently though, it stopped working in chrome, while keep working in firefox, safari, and other apps.

Do you have any advice?

Chrome: 90.0.4430.93 OS: 10.15.7

Thanks!

danielktaylor commented 3 years ago

Stops working for me about once a day in Chrome, if I restart Chrome it works again.

danielktaylor commented 3 years ago

I can confirm that when it doesn't work in Chrome (until you restart chrome), it still works in Safari.

Desousak commented 3 years ago

I think might have to do with a conflict between SensibleSideButtons and Chrome - the navigation in Chrome seems to work again if SensibleSideButtons is closed. I've created a branch based on @bojanin's work which disables the app's functionality within Chrome specifically and navigation when using the side buttons still works as expected.

ben-xo commented 3 years ago

If there's a way to unhook this from Chrome only, that would be awesome.

ben-xo commented 3 years ago

I think might have to do with a conflict between SensibleSideButtons and Chrome - the navigation in Chrome seems to work again if SensibleSideButtons is closed. I've created a branch based on @bojanin's work which disables the app's functionality within Chrome specifically and navigation when using the side buttons still works as expected.

Nice! Any chance you could turn that into a proper pull request?

What's the reason for adding the nil at the end of the list?

Desousak commented 3 years ago

I think might have to do with a conflict between SensibleSideButtons and Chrome - the navigation in Chrome seems to work again if SensibleSideButtons is closed. I've created a branch based on @bojanin's work which disables the app's functionality within Chrome specifically and navigation when using the side buttons still works as expected.

Nice! Any chance you could turn that into a proper pull request?

What's the reason for adding the nil at the end of the list?

I plan to! Before I do, I wanted to implement some UI to allow for adding/removing new applications onto the block list.

As for the nil, I mainly followed Apple's documentation for the arrayWithObjects method. I'm fairly new to macOS development, so I can't say why it's needed in particular, haha.

Cyberbeni commented 3 years ago

Please also add "com.microsoft.edgemac" to the list.

varargs in Objective-C are usually nil terminated, so it is required at the end of arrayWithObjects