Issue #12 - Dynamic enable/disable plugins by filename

archangelic / pinhook

the pluggable python framework for IRC bots and Twitch bots

https://archangelic.github.io/pinhook/

MIT License

31 stars 4 forks source link

Issue #12 - Dynamic enable/disable plugins by filename #61

Closed JKirchartz closed 5 years ago

JKirchartz commented 5 years ago

This adds a whitelist and blacklist commands and configuration settings for operators and owners to use respectively. This allows plugins to be enable and disable on the fly.

this will :

allow ops to add plugin filenames to a whitelist or a blacklist
remove items from the whitelist when added to the blacklist and vice versa
enable/disable every command and listener in the plugin file
allow "whitelist" and "blacklist" kwargs when constructing a Bot
create a whitelist from loaded plugins if none exists

archangelic commented 5 years ago

So, it looks like you did this off of an earlier version. So a little feedback:

i have changed the attributes in init from using the function to using kwargs.get('kwarg', default_value)
all commands should be prepended with self.cmd_prefix
I think the commands should be named enable and disable. I think it is clearer what it does. I don't care what the variables are called in the code otherwise.

archangelic commented 5 years ago

I’m going to close this PR as it has been a while and some core changes have been made.