archdotdev / tap-service-titan

Singer tap for Service Titan built with the Meltano SDK
Apache License 2.0
1 stars 0 forks source link

feat: job history and reviews streams #29

Closed cjohnhanson closed 1 month ago

cjohnhanson commented 1 month ago

This adds the job history and reviews streams and includes some cleanup of docstrings for other streams.

The job history stream is returning 403s in my testing with our test tenant credentials. If the URL were malformed, it would return a 404. Requests are structured identically to other export streams and if query params were malformed, the requests would still largely complete successfully but would potentially just not paginate properly and the tap would just keep running.

I think that this may be a matter of ST throttling job history requests for dev/integration environments. This endpoint returns full history for every job and is likely to be the highest volume of any endpoint, so it potentially makes sense that they'd want to throttle in integration environments.

With all the above in mind and considering that no other streams are impacted here and that this endpoint adheres to the same export pagination logic as the other export endpoints we already use, I'd like to go ahead and merge and then we can see job history export behavior against a production integration and go from there.