search

archen / django-tests

Vagrant box to provide a known-functioning and consistent environment for Django contributors to test changes before committing to the repo.
6 stars 0 forks source link

Python 3 isort installation issue #6

Open archen opened 9 years ago

archen commented 9 years ago

in the python role, isort installation is failing in the python 3 provisioning steps as there is a conflict with configparser in a dependent package. If anyone has a quick fix for this, please feel free to take it on.

timgraham commented 9 years ago

I haven't seen this before. Could you post the traceback?

timgraham commented 9 years ago

I think the issue is that isort doesn't support Python 3.2. It should be fine to let this fail. Does it prevent the provisioning script from proceeding? On the Jenkins cluster it doesn't.

archen commented 9 years ago

It reports failure in the vagrant provisioning, but I haven't yet verified the state of the environment post-failure. I'll poke around tomorrow to see if the other Python 3.x environments are still configured fine.

So, is isort explicitly excluded from the 3.2 tests?

— Sent from Mailbox

On Sun, May 17, 2015 at 8:04 PM, Tim Graham notifications@github.com wrote:

I think the issue is that isort doesn't support Python 3.2. It should be fine to let this fail. Does it prevent the provisioning script from proceeding? On the Jenkins cluster it doesn't.

Reply to this email directly or view it on GitHub: https://github.com/archen/django-tests/issues/6#issuecomment-102872011

timgraham commented 9 years ago

isort isn't required for running the tests. It's used for a pull request check which only runs on Python 3.4. It might be useful to have installed if a developer wanted to run that check in the VM, but it's probably easiest just to remove it from this project, at least for now.

archen commented 9 years ago

Awesome! Thanks for the info.

— Sent from Mailbox

On Sun, May 17, 2015 at 8:24 PM, Tim Graham notifications@github.com wrote:

isort isn't required for running the tests. It's used for a pull request check which only runs on Python 3.4. It might be useful to have installed if a developer wanted to run that check in the VM, but it's probably easiest just to remove it from this project, at least for now.

Reply to this email directly or view it on GitHub: https://github.com/archen/django-tests/issues/6#issuecomment-102876697