archerne / hastarlink

Starlink Statistics and Alerts Integration
GNU General Public License v3.0
10 stars 1 forks source link

Log SPAM #10

Closed philcanman closed 1 year ago

philcanman commented 1 year ago

I was wondering if there is a way to stop the polling data from showing up in the HA logs? It post about every second and makes it hard to view other issues.

archerne commented 1 year ago

@philcanman I don't currently have any logs in my HA logs from starlink. Do you have your logger turned on all of HA to higher than info?

philcanman commented 1 year ago

Sorry I was not clear here. I am referring to the HA container logs. Not sure if I am able to switch the log level there. Thanks for providing this integration, makes for a nice ISP dashboard.

leadZERO commented 1 year ago

I noticed the same very verbose logging on my HA/docker. I think https://github.com/archerne/hastarlink/pull/11 fixes this.

I looked for a way to not have to modify dish_grpc_text.py since it's really imported from the other source. However, I think the root of the problem is that it currently printing to standard out AND returning the lines in an array. Unfortunately we depend on one of those functions but can't separate them without modifying the file...

Thoughts?

archerne commented 1 year ago

I just pushed a fix, can you check and see if that solved anything for you? I removed my calls to the grpc_text python file, those were old files before i integrated the core library and I hadn't taken the time to update them yet. I changed it instead to actually call the core library to get the status data and the location data. Hopefully that eliminates some of the Log spam and it simplifies the code as well.

leadZERO commented 1 year ago

Looks fixed!

archerne commented 1 year ago

Fixed with commit 9d49bae