archesproject / arches-for-science

Arches for Science
13 stars 9 forks source link

Advancing to final step of sample taking without taking one raises TypeError #1480

Open jacobtylerwalls opened 10 months ago

jacobtylerwalls commented 10 months ago
  1. Sample Taking > add a sample > finish workflow
  2. Sample Taking > select the same parent physical object
  3. Advance past sample taking step without creating a sample

My guess is that you should not be able to advance to the final step without new samples.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading '0')
    at viewModel.eval (sample-taking-final-step.js:123:71)
    at Function.notifySubscribers (knockout-latest.js:42:453)
    at Function.wa (knockout-latest.js:47:255)
    at c (knockout-latest.js:46:494)
    at eval (summary-step.js:10:16)
chiatt commented 9 months ago

Yeah - that's right. The user needs to create a sample in order to proceed.