archesproject / arches-for-science

Arches for Science
GNU General Public License v3.0
13 stars 9 forks source link

Remove hard-coded sample logic #1516 #1535

Closed jacobtylerwalls closed 9 months ago

jacobtylerwalls commented 10 months ago

Closes #1516

~TODO: check report workflow once I can load it~

jacobtylerwalls commented 10 months ago

Cool, I added handling for that, but to reproduce the issue I had to create a physical thing without a name, and that causes issues all over the workflows, e.g.:

resource.js:20 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'results')
    at eval (resource.js:20:44)
    at async Promise.all (index 0)