search

archesproject / arches-her

6 stars 12 forks source link

Fix for ajax console error when deleting tile/row from table #1298

Closed SDScandrettKint closed 2 months ago

SDScandrettKint commented 3 months ago

Closes: #1292

The change in jquery versions between Arches version 6 and 7 means that the .success method no longer works; now success is a part of the ajax call.

The deletion ajax call now works, and the deletion is reflected in the table and node tree.

SDScandrettKint commented 3 months ago

This change has uncovered a new bug when moving away and back to the Associated resources tab, where the table length is not updated, causing UI and console errors as shown below:

https://github.com/user-attachments/assets/ae7d2f02-739d-4d73-8b09-48d3d6981148

This issue is not new to the v7 AfHER branch and was present in v6.

Note that the error is the same as issue #1277, confirming that this error refers to the table length

aj-he commented 3 months ago

@SDScandrettKint - this was raised but then you pointed out addition issues. Is there anything else to come?

aj-he commented 2 months ago

Closed in favour of PR #1337 which includes additional fixes for the delete button