search

archesproject / arches-her

6 stars 12 forks source link

1326 Add Spinny When Waiting for Correspondence #1331

Closed csmith-he closed 2 months ago

csmith-he commented 2 months ago

Closes #1326

When user presses the save button in the Correspondence Workflow a spinny with the message 'Generating correspondence for consultation' appears.

This clears once the correspondence is generated or the process fails.

SDScandrettKint commented 2 months ago

The PR works well, however, I've noticed that when throttling the network through Firefox, the "Select Related Consultation" dropdown reappears for a short period of time still. It reappears between the "Save and continue button" being clicked and line 77 where the message and loading are fired, which is much shorter than before but can still be confusing for the user. See video for an example:

https://github.com/user-attachments/assets/91db855c-3cbe-4640-8dd6-c97857fb02e7


However, if the line self.saving(true); is added after self.tile().save().then(function(tile) { as shown in the screenshot below...

... then the "Select Related Consultation" dropdown is hidden much quicker (almost a flash):

https://github.com/user-attachments/assets/79801b04-f73b-4cfc-90f4-3995bacfb358