archesproject / arches

Arches is a web platform for creating, managing, & visualizing geospatial data. Arches was inspired by the needs of the Cultural Heritage community, particularly the widespread need of organizations to build & manage cultural heritage inventories
GNU Affero General Public License v3.0
212 stars 142 forks source link

fixes webpack settings location logic #10989 #11007

Closed chrabyrd closed 4 months ago

chrabyrd commented 4 months ago

Types of changes

Description of Change

This fixes a regression that happens as a result of earlier dev/7.6.x webpack changes. As of dev/7.6.x, webpack programmatically finds a project's settings.py file. This breaks if there's a folder that is visited earlier in the recursion that also has a settings.py file.

Issues Solved

Closes #10989

Checklist

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Further comments

To test:

  1. Start on dev/7.6.x
  2. Create a project with a name beginning with c or later. ( eg foo )
  3. Create a build folder in the project root ( level with pyproject.toml )
  4. Add a blank settings.py file in the build folder
  5. Watch the webpack build process fail.
  6. Check out this branch
  7. Watch the webpack build process succeed.