archesproject / arches

Arches is a web platform for creating, managing, & visualizing geospatial data. Arches was inspired by the needs of the Cultural Heritage community, particularly the widespread need of organizations to build & manage cultural heritage inventories
GNU Affero General Public License v3.0
212 stars 142 forks source link

Rework webpack filepath to allow symlinks and remove character combin… #11014

Closed bferguso closed 3 months ago

bferguso commented 4 months ago

…ation collision issues (eg js)

Types of changes

Description of Change

Reworked the webpack file lookup logic to avoid using any special character combinations in the path that were causing issues, and updated so symlinks to outside files can be properly resolved.

Issues Solved

Closes #10791

Checklist

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

Further comments

Have not done any ancillary work to complete this PR. Submitting for feedback. Collapsed JS, Template and Image file lookup functions into a single function as most of the logic was the same. Didn't make changes to the vue lookup function as I don't have any vue components to test against.

chrabyrd commented 3 months ago

Overall looks good! After our slack conversation I was able to incorporate this in 7.6 with this PR. I'll add you as a reviewer 👍

There are some minor discrepancies between our implementations that should be reconciled -- happy to chat about them any time