Open chrabyrd opened 2 weeks ago
Still waiting to update 7.6.0.md and maybe arches-docs, but wanted to get agreement on method beforehand 👍
After talking with you @chrabyrd, it makes sense what you're trying to do here. It is nice to have a system that just works when you deploy it, and this will go a long way towards doing that. At the same time I keep wondering if we're being too prescriptive in the project templates. Perhaps not, but assuming that user will make use of github actions in their project may or may not be true. That makes me wonder if this should be in core (or perhaps broken out into some other repository? obviously that would add complexity and perhaps make this moot). At the same time, I fully understand and appreciate the reasoning behind this PR. To be clear - I have no real objections to this method.
After talking with you @chrabyrd, it makes sense what you're trying to do here. It is nice to have a system that just works when you deploy it, and this will go a long way towards doing that. At the same time I keep wondering if we're being too prescriptive in the project templates. Perhaps not, but assuming that user will make use of github actions in their project may or may not be true. That makes me wonder if this should be in core (or perhaps broken out into some other repository? obviously that would add complexity and perhaps make this moot). At the same time, I fully understand and appreciate the reasoning behind this PR. To be clear - I have no real objections to this method.
:wave: @aarongundel !
I appreciate the insight. Yeah I had thought of making this into an Arches application, and therefore having it be an easy drop-in for projects that desire it. However it seems that Github actions are one of the few things that won't work with an arches application -- it requires the .github
folder and associated files to be physically in the repo. And you're right, it's an assumption that the project will use github to host their Arches project, and that they'll want to use actions. However I'm of the mind that automatic linting/testing/coverage check will want to largely be used and we should make it as easy as possible to implement. I guess if the argument boils down to opt-in or opt-out, I believe that it makes more sense for a project to be opt-out.
Un-couching this now 👍
Types of changes
Description of Change
Allows to GH test runners to work with ARCHES_APPLICATIONS
Issues Solved
Closes #11049
Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments