Arches is a web platform for creating, managing, & visualizing geospatial data. Arches was inspired by the needs of the Cultural Heritage community, particularly the widespread need of organizations to build & manage cultural heritage inventories
GNU Affero General Public License v3.0
216
stars
144
forks
source link
Move compatibility check from Django template to system check #11114 #11189
[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Description of Change
Avoid maintaining a project's range of compatible arches versions in two places. Also, allows the error to surface even if an application is not rendering Django templates (e.g. vue app only).
Issues Solved
Closes #11114
Checklist
I targeted one of these branches:
[x] dev/7.6.x (under development): features, bugfixes not covered below
[ ] dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
[ ] dev/6.2.x (extended support): major security issues, data loss issues
[x] I added a changelog in arches/releases
[ ] I submitted a PR to arches-docs (if appropriate)
[ ] Unit tests pass locally with my changes
[ ] I added tests that prove my fix is effective or that my feature works
[ ] My test fails on the target branch
Ticket Background
Sponsored by: Getty Conservation Institute
Found by: @jacobtylerwalls
Testing considerations
python manage.py check (or showmigrations, etc)
test project (without pip installation)
test pip-installed arches application
test missing arches requirement
test invalid arches requirement (not semantic)
test requirement too high, too low, exact pin to wrong version
Types of changes
Description of Change
Avoid maintaining a project's range of compatible arches versions in two places. Also, allows the error to surface even if an application is not rendering Django templates (e.g. vue app only).
Issues Solved
Closes #11114
Checklist
Ticket Background
Testing considerations
python manage.py check (or showmigrations, etc)