search

archesproject / arches

Arches is a web platform for creating, managing, & visualizing geospatial data. Arches was inspired by the needs of the Cultural Heritage community, particularly the widespread need of organizations to build & manage cultural heritage inventories
GNU Affero General Public License v3.0
212 stars 143 forks source link

disallowed from adding a node to ontology-enabled graph #3811

Closed adamlodge closed 6 years ago

adamlodge commented 6 years ago

Describe the bug When adding a node to an ontology-enabled graph, I get an error telling me that I need to define the ontology property of the new node even when the "relationship to parent" is already defined. I see two problems here:

  1. I can make the node I need
  2. There is a disconnect between the language in the error message and the language in the UI. UI only speaks of relationship to parent, where error message speaks of ontology property. Both are accurate and valid, but a more naive user might not know that they are one and the same.

To Reproduce Steps to reproduce the behavior: Build the graph as described in the screenshot below

Screenshots If applicable, add screenshots to help explain your problem.

Expected behavior A clear and concise description of what you expected to happen.

Your Arches Information

Additional context Add any other context about the problem here.

Ticket Background

azaroth42 commented 6 years ago

+1 to this issue.

I updated to master as of 2018-08-01 and after making changes to the configuration of the graph nodes and cards, no new nodes or deleted nodes, the relationship between the root and several nodes had been reset to None. This means no further changes can be made (e.g. to fix the missing relationship) as the consistency of the graph is broken in two places and the graph must be saved before switching from the first to the second (and now third and fourth!)

This blocks me from testing the API work, as I can't make the cards to enter data to then test the retrieval.

chiatt commented 6 years ago

@adamlodge Can you try to rebuild the graph presented in the ticket? I'm able to create it without any errors. If you still see errors let me know. Perhaps I'm doing something differently in building the graph than you are.

azaroth42 commented 6 years ago

I can only reproduce the error by editing data in the cards and then coming back to the graph view.

I also can't do it in a clean install of master at the moment, as another bug means we can't make new models!

azaroth42 commented 6 years ago

Steps from clean install of current master:

Now New Node's relationship will be gone.

chiatt commented 6 years ago

@adamlodge and @azaroth42 I've merged a fix for this into master. Let me know if you see this issue occur again.

adamlodge commented 6 years ago

Looks good to me. Leaving open to give @azaroth42 a chance to test.

azaroth42 commented 6 years ago

:+1: that the case above is fixed. LGTM to close, and will open a new issue if there's another problem with similar symptoms that aren't addressed by this fix.