archesproject / arches

Arches is a web platform for creating, managing, & visualizing geospatial data. Arches was inspired by the needs of the Cultural Heritage community, particularly the widespread need of organizations to build & manage cultural heritage inventories
GNU Affero General Public License v3.0
219 stars 144 forks source link

Dockerfile is broken in stable/4.4.2 release #4971

Open benosteen opened 5 years ago

benosteen commented 5 years ago

Describe the bug Due to changes in yarn setup and configuration, and how projects are set up, the docker containerization configuration and scripts are broken and will fail. The first failure will due to not being able to find package.json in the root directory (as it has been relocated).

I had filed a pull request to fix this when some of these changes were made to the master branch, but it is waiting for reviewer approval still.

https://github.com/archesproject/arches/pull/4882

This breakage is due to the lingering effects of #4879 that were not resolved before making the 4.4.2 release

To Reproduce Steps to reproduce the behavior:

  1. Get github repository and switch to the stable/4.4.2
  2. Try to build the Docker image.

Expected behavior For the Dockerfile to correctly build a functioning container of the Arches application, and for the docker-compose.yml to be able to start a basic Arches application stack.

bptarpley commented 5 years ago

Until the Docker deployment for the latest version has been fixed, is there an existing release with a good, known-working Docker deployment? I'd very much like to get up and running with a dockerized deployment of Arches, even if it's not the latest version.

benosteen commented 5 years ago

The fixes were pushed into the master branch a few days ago so you can build and run a dockerized version from the current master. You can also use docker in the previous release (pre 4.4.2), though there have been some significant updates and changes to the Arches platform that testing using the latest version will be useful. I have recently rebuilt my latest docker image of Arches and I am running with that, so you should have success now. Let me know if you have problems!

Whether the fixes are pulled into 4.4.2 as a hotfix, or whether the docker fixes will be part of a later release is yet to be determined I think.

Ben

On Mon, 15 Jul 2019 at 12:27, Bryan Tarpley notifications@github.com wrote:

Until the Docker deployment for the latest version has been fixed, is there an existing release with a good, known-working Docker deployment? I'd very much like to get up and running with a dockerized deployment of Arches, even if it's not the latest version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/archesproject/arches/issues/4971?email_source=notifications&email_token=AABAX4ED3UHH7FTXRGA623TP7TFTRA5CNFSM4H5IAAIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6W7PQ#issuecomment-511537086, or mute the thread https://github.com/notifications/unsubscribe-auth/AABAX4HJCBRGJXLR7ODJARTP7TFTRANCNFSM4H5IAAIA .

bptarpley commented 5 years ago

Awesome! Thank you for letting me know--I'll definitely give it a shot tomorrow and report back if I have any issues.

bptarpley commented 5 years ago

I finally got around to attempting this, and it looks like there's a problem with the way the arches container attempts to start gunicorn:

../entrypoint.sh: line 345: gunicorn: command not found

Steps to reproduce:

git clone https://github.com/archesproject/arches.git
cd arches
docker-compose build --no-cache
docker-compose up
benosteen commented 5 years ago

My bad. When I shifted the packages into a multistage build and run, I failed to re-add the gunicorn server install to the run section (even though the build section builds it!). I had thought about making a requirements_docker.txt to track the small additional files, but didn't in the end. I'll patch this and put in a pull request for it today.

Ben

On Thu, 18 Jul 2019 at 12:04, Bryan Tarpley notifications@github.com wrote:

I finally got around to attempting this, and it looks like there's a problem with the way the arches container attempts to start gunicorn:

../entrypoint.sh: line 345: gunicorn: command not found

Steps to reproduce:

git clone https://github.com/archesproject/arches.git cd arches docker-compose build --no-cache docker-compose up

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/archesproject/arches/issues/4971?email_source=notifications&email_token=AABAX4HGZKBMDYJG4YOULJDQAC5EBA5CNFSM4H5IAAIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2JPBGQ#issuecomment-512946330, or mute the thread https://github.com/notifications/unsubscribe-auth/AABAX4FDVLAZDIALU7PNIZ3QAC5EBANCNFSM4H5IAAIA .