search

archetype-themes / plugin-theme-component

A Shopify CLI plugin for building theme components.
MIT License
9 stars 4 forks source link

Output component.css instead of component.css.liquid #335

Closed t-kelly closed 8 months ago

t-kelly commented 8 months ago

Current Situation We are currently outputting our main stylesheet as a liquid file. There is no Liquid in it. Let's not encourage using any.

Proposed solution Output component.css only

bertiful commented 8 months ago

Also, proposal to prefix our theme specific CSS, for both our components and overrides files: theme-components.css and theme-overrides.css.

montalvomiguelo commented 8 months ago

+1 output without .liquid extension

@bertiful What are we trying to solve with prefixes?

bertiful commented 8 months ago

It's not a solution to a problem; it's a proposal to be more prescriptive about the file name and namespace it such that we know exactly what that file is without question. I see overrides.css and that to me could be overrides for anything. My two cents, I don't have a strong opinion on this.

charlie-quinn commented 8 months ago

It's not a solution to a problem; it's a proposal to be more prescriptive about the file name and namespace it such that we know exactly what that file is without question. I see overrides.css and that to me could be overrides for anything. My two cents, I don't have a strong opinion on this.

I like this idea as a less technical person, but also have no strong opinions 😅