archetyped / simple-lightbox-extensions

Feedback & Support for Simple Lightbox Extensions
https://archetyped.com/tools/simple-lightbox/
2 stars 3 forks source link

[WooCommerce / Issue]: Error: Missing Argument (2) #60

Closed Markmcl closed 4 years ago

Markmcl commented 7 years ago

Description of issue

Hello since the latest update to Woocommerce I get the following warning

Warning: Missing argument 3 for SLB_WooCommerce::activate_product_thumbnail(), called in /home/username/public_html/amazing/wp-includes/class-wp-hook.php on line 298 and defined in /home/username/public_html/amazing/wp-content/plugins/slb-woocommerce_0.2.1/controller.php on line 107

Woo has changed how it handles images so suppose this is the problem

Details

Markmcl commented 7 years ago

more details everything is completely up to date I should have looked, but it appears 'smooty1970' is having the same or very similar issue. I am using a child theme of Woo's Storefront theme, & have done the usual tests to try and isolate the problem. The site isn't public yet, but could make available and email link if necessary

archetyped commented 7 years ago

Hi, please fill in the details of your issue and I would be glad to take a look. Versions can change frequently, so noting the specific version you are using is very important.

Thanks.

Markmcl commented 7 years ago

I left this for a few days to see if anticipated updates to Woocommerce changed anything however no luck. Here is a page exhibiting the problem: https://amazingmomentscq.com.au/product/woo-album-1/ I have tested in Firefox, Chrome,& Edge WooCommerce version is 3.0.3. There has only been a problem since WC v 3 SLB v 2.6 SLB: WC Activator v 0.2.1 theme is a child of Woo Commerce Storefront

Other plugins All In One SEO Pack not activated AntiVirus Autoptimize not activated BackupBuddy BNE Gallery Extended BNE Testimonials Breadcrumb Trail Cart to Quote for Woocommerce Envato Market Gmail SMTP Google Apps Login HTML Editor Syntax Highlighter Jetpack Login Logo Manual Control for Jetpack Menu Humility Meteor Slides Monomeath WooCommerce shop display Remove Widget Titles Reveal IDs Shield Show Current Template Sidebar Login Simple Catalog for WooCommerce Simple Lightbox Simple Lightbox: WooCommerce Activator Storefront Footer Bar Sucuri Security TinyMCE Advanced UpdraftPlus not activated WooCommerce WP Super Cache not activated

archetyped commented 7 years ago

Thank you, I have updated your original post with the details you have provided.

I have confirmed your issue. Changes to major version numbers generally mean there are potentially breaking changes, so I am currently evaluating the changes to WooCommerce to see what needs to be done to make the add-on compatible with the new version.

Thanks.

Markmcl commented 7 years ago

Hello I was wondering if you have an update for this? thanks

mattgipson commented 7 years ago

I just bought the plugin and I am getting the same issue out of the gate. Any update or fix suggestion for this @archetyped ?

archetyped commented 7 years ago

Hi @Markmcl, WooCommerce has completely changed its image implementation in v3+, so development on supporting v3+ is currently underway.

@mattgipson are you using WooCommerce v3+ or an earlier version? As noted on the add-on's page, support for WooCommerce v3+ is coming soon. If you are using an earlier version, please create a new ticket for your issue and I would be glad to take a look.

Thanks.

OnnoGabriel commented 5 years ago

Hi, any update on this? Is WooCommerce v3+ supported now?

archetyped commented 4 years ago

SLB's WooCommerce Extension now supports WooCommerce v3+ (including v4+).