archetyped / simple-lightbox

The highly customizable lightbox for WordPress
http://archetyped.com/tools/simple-lightbox/
GNU General Public License v2.0
73 stars 33 forks source link

[Feedback]: A masterpiece #823

Closed ddegner closed 4 years ago

ddegner commented 4 years ago

I've been searching for this functionality in JetPack's carousel but you did it with even more elegance than I could imagine. The key features that you included are:

1) Turn all photos on a page into a slideshow 2) Include captions 3) Fill the screen with the photo

I'm just starting playing around with this but I hope to find a few more features

4) Easy theming 5) Preloading of images

archetyped commented 4 years ago

Glad to hear you're enjoying SLB 😄

Custom themes are simple with just some HTML/CSS. See SLB's documentation for more information on creating custom lightbox themes.

ddegner commented 4 years ago

Thanks for the info. I was able to edit the style sheet directly (I’m sure I’ll loose it when I update the plugin).

Unfortunately the https://archetyped.com/know/slb-theme-anatomy/ page makes no sense to me. I’ve done a fair share of programming in PHP, but the instructions could be more specific about which file I need to edit to add a theme to the theme selector, where should I place the custom theme folder so they don’t get deleted when updating.

It really is a great script. Elegant is the correct word. There isn’t any cruft but it is flexible.

archetyped commented 4 years ago

Perhaps you missed the paragraph at the start of the tutorial?

This tutorial covers adding a custom theme as a WordPress plugin, but it could also be done as part of a theme with a few simple modifications.

How the lightbox theme is added (via plugin or as part of a WP theme) would determine where the lightbox theme code should go.

The plugin-based approach is the most flexible, so directly below is a section titled Follow Along with a link to download a starter lightbox theme in the form of a WordPress plugin, so everything regarding where to place the code is already taken care of for you.

If someone wanted to add it to their WP theme instead, they would be the best person to determine where the respective code should be added so that it is loaded with WordPress depending on how they've set up their theme.

Let me know if there is anything that is still unclear in the theme tutorial, and I would be glad to take a look.