search

archi-contribs / jarchi-single-page-html-export

Generate a single-page HTML export from Archi
22 stars 6 forks source link

Always use hamburger icon #2

Closed jbsarrodie closed 4 years ago

Phillipus commented 4 years ago

FYI - a hamburger icon is used in both states in Firefox and Mac Notifications.

jbsarrodie commented 4 years ago

Yes, that's also true on GMail and Outlook, so let's go for it.

I wonder if making the sidebar full height (and thus moving the top bar) wouldn't be a good feedback in addition.

Phillipus commented 4 years ago

I wonder if making the sidebar full height (and thus moving the top bar) wouldn't be a good feedback in addition.

Not sure what you mean?

jbsarrodie commented 4 years ago

Not sure what you mean?

Something like that: image

Phillipus commented 4 years ago

Not sure how other UIs do it like that...will check...

Phillipus commented 4 years ago

I think like that it implies that the bottom area will hide?

jbsarrodie commented 4 years ago

And what about this : https://www.w3schools.com/w3css/tryit.asp?filename=tryw3css_sidebar_shift

Phillipus commented 4 years ago

I know you want to try that... ;-)

jbsarrodie commented 4 years ago

I've implemented the following changes:

When the sidebar is closed, we have an hamburger icon: image

And when the sidebar is opened, it takes the full height and shows a close icon: image

I think it makes more sens, so I'm commiting this (in fact it is already commited).

If someone want something else, then another issue will be created.

Phillipus commented 4 years ago

If someone want something else,

I want gherkins with my hamburger...