Improvements - Githubissues

archicoop / CookieLawManagement

Cookie Law Management is an easy to use plugin that allows to show privacy information, manage website cookies and get consent to install. It is compliant with EU Law and Italian Law (more restricitve).

5 stars 3 forks source link

Improvements #2

Closed instruccionesaldorso closed 6 years ago

instruccionesaldorso commented 6 years ago

@Nostrabramus I improved some stuff:

Remove empty files (if nothing is there for Extbase, you can skip its creation).
Rename TypoScript files according to new standards.
Use localization service from TYPO3, and you don't have to take care of prefixes for locallang.xlf files. Just having them in place will allow TYPO3 to search for the labels there directly.

instruccionesaldorso commented 6 years ago

It is good that you have under ext_emconf.php file a psr-4 section for composer installations auto-detect your class.

instruccionesaldorso commented 6 years ago

By the way, your version from TER has a "MACOSX" folder on the root, it would be nice to remove it.

Nostrabramus commented 6 years ago

Thanks a lot @instruccionesaldorso, we are reviewing it