new maduradocs-4.5 (retry)

[GoogleCodeExporter]

New maduradocs patch plus additions for dependent products (xcluder and
freehep). Thanks.

Original issue reported on code.google.com by roger.parkinson35 on 8 Apr 2010 at 6:07

Attachments:

• org.freehep.patch
• gr.abiss.xcluder.patch
• maduradocs-4.5.patch

[GoogleCodeExporter]

Original comment by archie.c...@gmail.com on 8 Apr 2010 at 2:08

• Changed state: Started
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

I'm wondering if xcluder should have the dependency on ant.

Since it is an ant task, you obviously can't use it without already having ant.
Moreover, if you did resolve it using ivy, you would get the ant jar as well 
and then
if you tried to use both jars the duplicate ant classes might cause problems.

I will remove this dependency for now... let me know if you think it still 
needs to
be there.

Added in r1163.

Original comment by archie.c...@gmail.com on 8 Apr 2010 at 2:15

[GoogleCodeExporter]

This stuff doesn't belong:

+       <dependencies>
+        ...
+        <exclude org="*" ext="*" type="source"/>
+        <exclude org="*" ext="*" type="javadoc"/>
+       </dependencies>

the way to exclude source and javadoc is by specifying type="jar" in your 
resolution
(and/or perhaps in this case, "xml").

Also, if "default" is defined by default if no other configurations are present 
so
this is unnecessary:

+    <configurations>
+        <conf name="default" description="Normal usage"/>
+    </configurations>

Finally, your <dependency> tags are missing "conf" attributes which are 
required in
ivy roundup. They'll probably mostly be conf="default->default" but you should 
verify
this and let me know.

Original comment by archie.c...@gmail.com on 8 Apr 2010 at 2:28

• Changed state: Feedback

[GoogleCodeExporter]

re xcluder/ant dependency. Probably fine. I copied it from the POM file but, 
like
you, I can't think of a scenario it would be needed.

re ivy file. I have attached a fresh patch file (maduradocs-4.5.patch2) with the
changes made, ie removed default conf, added confs to dependencies, removed bad 
excludes.

Thanks

Original comment by roger.parkinson35 on 9 Apr 2010 at 3:07

Attachments:

• maduradocs-4.5.patch2

[GoogleCodeExporter]

Thanks, added in r1164.

Original comment by archie.c...@gmail.com on 9 Apr 2010 at 9:54

• Changed state: Fixed