search

archiecobbs / mod-authn-otp

Apache module for one-time password authentication
Apache License 2.0
63 stars 17 forks source link

Fix genotpurl on ARM #46

Closed fancsali closed 2 years ago

fancsali commented 2 years ago

The char type defaults to signed on intel but to unsigned on ARM, which causes all sorts of issues. This commit ensures, its always explicitly specified which one the code needs.

This would cause the genotpurl command to output an incorrectly base32-encoded secret, thus showing an incorrect URL.

archiecobbs commented 2 years ago

Thanks for identifying this bug! Should be fixed by b42bdca.

fancsali commented 2 years ago

Hello Archie,

Thanks for your quick response.

Would be super kind, to mention the name of your contributors somewhere apart from the closed PRs themselves.

Cheers, Dan

On Wed, 27 Apr 2022 at 14:32, Archie L. Cobbs @.***> wrote:

Closed #46 https://github.com/archiecobbs/mod-authn-otp/pull/46.

— Reply to this email directly, view it on GitHub https://github.com/archiecobbs/mod-authn-otp/pull/46#event-6507559000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMXX6GZFXWFT7JCBKKDYTLVHFFXDANCNFSM5UO4IFQA . You are receiving this because you authored the thread.Message ID: @.***>

archiecobbs commented 2 years ago

Sure thing, see updated commit 9888cf1b.

fancsali commented 2 years ago

Good afternoon,

Cheers.

Hate to be nitpicking, but I am afraid, the s and the c are in the wrong order in my handle... Would you awfully mind to fix that typo?

Regards, Dan

On Wed, 27 Apr 2022 at 21:39, Archie L. Cobbs @.***> wrote:

Sure thing, see updated commit 9888cf1 https://github.com/archiecobbs/mod-authn-otp/commit/9888cf1b4a9f875c8a2aae66963473c2d0d03550 .

— Reply to this email directly, view it on GitHub https://github.com/archiecobbs/mod-authn-otp/pull/46#issuecomment-1111509795, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMXX6F4PQXMYBBZMEGGUBDVHGX2RANCNFSM5UO4IFQA . You are receiving this because you authored the thread.Message ID: @.***>

archiecobbs commented 2 years ago

Oops, sorry about that! Should be fixed in af4b196.

fancsali commented 2 years ago

Hello,

Thanks a lot.

I was also wondering, whether you had plans to release a new version with all the bits and bobs since 1.1.9?

Regards, Dan

On Thu, 28 Apr 2022 at 20:56, Archie L. Cobbs @.***> wrote:

Oops, sorry about that! Should be fixed in af4b196 https://github.com/archiecobbs/mod-authn-otp/commit/af4b19653cebde8b6f8c88bb3a52a0d127976485 .

— Reply to this email directly, view it on GitHub https://github.com/archiecobbs/mod-authn-otp/pull/46#issuecomment-1112646830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMXX6GIQQUUOWLX4CCAPJ3VHL3O5ANCNFSM5UO4IFQA . You are receiving this because you authored the thread.Message ID: @.***>

archiecobbs commented 2 years ago

Good idea, it's been a while. Done.