respect user provided search limit argument

[bnjm]

Scope & Features

• Since commit 6685969 we haven't been respecting the { limit } argument in io3d.furniture.search

Design

• the limit parameter now uses either the argument provided by the user or falls back to the default of 50

How to use

• io3d.furniture.search('chair', { limit: 5 })

How to test

• compare io3d.furniture.search('chair', { limit: 5 }) in this branch compared to master

[bnjm]

To better explain...

Before this PR:

io3d.furniture.search('office', { limit: 5 })
 // 203 results

io3d.furniture.search('', { limit: 1000 })
 // 500 results

After this PR:

io3d.furniture.search('office', { limit: 5 })
// 5 results

io3d.furniture.search('', { limit: 1000 })
// 957 results

[tomas-polach]

@bnjm @m-ke thx for taking care of this :) 👍 do we have any blockers from also adding the offset param? means: outcomenting

• https://github.com/archilogic-com/3dio-js/blob/master/src/furniture/search.js#L13
• https://github.com/archilogic-com/3dio-js/blob/master/src/furniture/search.js#L26

[m-ke]

I was just looking at it as well... I don't think there are any blockers there. I'd suggest we coordinate the release tomorrow afternoon.