Make storage.get work for getting any data out of s3 storage

archilogic-com / 3dio-js

JavaScript toolkit for interior apps

https://3d.io

MIT License

273 stars 73 forks source link

Make storage.get work for getting any data out of s3 storage #140

Open ghost opened 6 years ago

ghost commented 6 years ago

Scope

Make storage.get work for getting data out of s3 storage like the name suggests, instead of fetching and parsing data3d only

Behaviour

Expected behaviour: Get data from storage
Actual:

// WIP: for now, assume that this is only being used for data3d
How about not assuming that

Implications

Not sure changing this would break something that exists now
Let's have a short discussion about it here

ghost commented 6 years ago

@frederic-schwarz can i try and fix this without breaking many things, or should i leave it for now? It would be nicer to put the method in the place where it belongs before i call it from my data3d exporter code