fix tour for aframe >= 0.8.0 - Githubissues

archilogic-com / 3dio-js

JavaScript toolkit for interior apps

https://3d.io

MIT License

273 stars 73 forks source link

fix tour for aframe >= 0.8.0 #144

Closed BoryaMogila closed 5 years ago

BoryaMogila commented 5 years ago

Scope & Features

aframe-animation-component does not work with aframe > = 0.8.0, because aframe has changed api to rotate the camera. I rewrote the tour component using animejs directly.

Design

Design has not changed

How to use

Change aframe-animation-component script to animejs script

Notes

I change tour example for test new functionality

tomas-polach commented 5 years ago

Thx!! I will have a look later today

BoryaMogila commented 5 years ago

Ok

tomas-polach commented 5 years ago

Looks good!

Only consideration: In combination with A-Frame 0.7 (tested with example-browsers/tour/index.html) it looks like the camera doesn't focus on the tour-waypoints correctly. Do you think you can fix that? If not, we could bump the 3dio.js version number to 2.0 - which would be the official version number supporting A-Frame 0.8. (Keeping 3dio.js 1.x for A-Frame 0.7 support)

BoryaMogila commented 5 years ago

I fix bug with 0.7.0 support. Now must work fine.

tomas-polach commented 5 years ago

Cool thx. Will test again. (Don't worry about the merge conflict. It's just the build files)

tomas-polach commented 5 years ago

Works correctly! Great! I will merge it and do a release on Thursday.

tomas-polach commented 5 years ago

One more change request: In order to not break earlier implementations using aframe-animation-component.js, could you please add this to component/tour.js:

var anime = window.anime || AFRAME.anime

and then use anime instead of window.anime here:

BoryaMogila commented 5 years ago

I add it. But its work only for aframe-animation-component >= 4.0.0

tomas-polach commented 5 years ago

Thx!

You are right. Earlier versions of the animation component are not exposing the anime library. Well, at least 4+ does...

BoryaMogila commented 5 years ago

ok

BoryaMogila commented 5 years ago

I add some fixes for older aframe versions after test on real plan. link for test plan.

tomas-polach commented 5 years ago

@BoryaMogila I did merge your changes and did a release with version number 2.0.0. I will update the docs accordingly later today. Pls. let me know if everything works as expected in your use case.

PS: I've set easing to easeInOutSine instead of linear because that was also the default in earlier 3dio.js versions.

Thanks again for your contribution :)

BoryaMogila commented 5 years ago

Hi. All works fine. I update test exemple