Get convertible texture ID's should be smarter and does not consider light maps

archilogic-com / 3dio-js

JavaScript toolkit for interior apps

https://3d.io

MIT License

276 stars 74 forks source link

Get convertible texture ID's should be smarter and does not consider light maps #93

Open Aadjou opened 6 years ago

Aadjou commented 6 years ago

When exporting a model via io3d.storage.export* this script is used to get convertible (aka. exportable) texture keys from the model:

'../utils/processing/get-convertible-texture-ids.js'

[x] The script does not consider light maps, this means our export formats that support light maps do not work.
[x] The script always returns all texture keys from the set (hi-res, lo-res and source) instead of the best quality texture of a set for conversion
[x] It should be configurable / optional to get light map keys and to "get texture sets" vs "get best texture for further processing"

tomas-polach commented 6 years ago

@Aadjou @bnjm is it ok if i assign this to me? started working on this 10min ago...

bnjm commented 6 years ago

Fine with me :) Will be a great improvement

Aadjou commented 6 years ago

Absolutely, thank you

tomas-polach commented 6 years ago

added lightmaps in: https://github.com/archilogic-com/3dio-js/commit/bc9ed812cdd44092addd3e3b86f62be43868d3e5
made getTextureKeys configurable to use source maps only: https://github.com/archilogic-com/3dio-js/commit/58082cc9f5b83f1a479c4d402fc583c1ea557daa

ghost commented 6 years ago

I'm reopening this issue as I'm currently reviewing 3d-js and unsure if this feature is finished, thanks @Aadjou

tomas-polach commented 6 years ago

@mope1 can you provide specific details why you reopened this one? (i guess you mean "3dio-js" instead of "3d-js" ?) i'm happy to help, just let me know

ghost commented 6 years ago

Because I'm not sure this issue is resolved and want to do some testing before i close it again

I looked at the code that finds texture keys in data3d model structures and it doesn't look like it can do everything needed, so i will test

tomas-polach commented 6 years ago

good point! let's add a unit test!

tomas-polach commented 6 years ago

created issue for unit test: https://github.com/archilogic-com/3dio-js/issues/129

Aadjou commented 6 years ago

we can already see in the get-convertible-textures code that only source textures are returned the goal is: source > hi-res (if not dds) > preview > none

ghost commented 6 years ago

exactly

tomas-polach commented 6 years ago

thx for the precise info, very much appreciated! :)