search

archilogic-com / aframe-gblock

Aframe component loading models from poly.google.com (inofficial)
MIT License
68 stars 14 forks source link

Update to work with poly #3

Closed urish closed 7 years ago

urish commented 7 years ago

Seems like gblock has been rebranded as poly: https://poly.google.com

I tried to use this component with modules from poly, but it seems to be broken. For instance:

<a-entity gblock="https://vr.google.com/objects/2tAgPX9As4I"></a-entity>

fails with an 404 error, even though the model exists (the above URL redirects to the new poly URL: https://poly.google.com/view/2tAgPX9As4I).

deprecatedcoder commented 7 years ago

It seems to me like this might just be a matter of changing line 118 and the following line in api-methods.js to point to http://poly.google.com/view, but I can't test it at the moment. If someone doesn't get to it before then, I will try and make the change, test and create a pull request.

AVGP commented 7 years ago

I think @tomas-polach is working on this

triptych commented 7 years ago

This breaks the demo as well - no tie fighters, no AT AT's :(

tomas-polach commented 7 years ago

fixed breaking vr.google.com legacy domains in:

added support for poly.google.com in:

@urish @triptych thx for making me aware of this! @deprecatedcoder thx! you were right: updating line 118 was key